doctor: fix missing loader.fail() call before showing how to fix manually on ios-deploy
#699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasbento
requested review from
Esemesek,
grabbou and
thymikee
as code owners
Closed
thymikee
reviewed
Sep 10, 2019
thymikee
approved these changes
Sep 10, 2019
Member
thymikee
left a comment
thymikee
left a comment
There was a problem hiding this comment.
Looking good! One more change and we can merge it
thymikee
approved these changes
Sep 10, 2019
thymikee
changed the title
loader.fail() call before showing how to fix manually on ios-deployloader.fail() call before showing how to fix manually on ios-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is part of the
react-native doctorissue at #694.It fixes a problem with the
ios-deployhealthcheck throwing an error without actually putting a final state in the loader, causing it to leak into the next healthcheck:It also changes some stuff regarding brew installation to keep consistency of what is being shown to the user (e.g. Watchman showing as
Installing watchmanafter you choose fix and the others showing withoutInstallingprefix).Before
After