docs: update commands on generating dev JS bundle for Android release #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Billydubb
requested review from
Esemesek,
grabbou and
thymikee
as code owners
thymikee
requested changes
Sep 10, 2019
Member
thymikee
left a comment
thymikee
left a comment
There was a problem hiding this comment.
Great, thank you! I feel we can make it simpler for an average user and show the details of how it works only when needed.
docs/commands.md
Outdated
|
|
||
| The expected path for the js bundle can be found on the line that starts with `jsBundleDir = `. | ||
|
|
||
| Alternatively you can simply set `bundleInDebug: true` in your app/build.gradle file, inside the `project.ext.react` map. |
Member
There was a problem hiding this comment.
I feel like we should highlight this fact and hide the rest behind a <detail> element
docs/commands.md
Outdated
|
|
||
| The expected path for the assets can be found in the react.gradle file on the line that starts with `resourcesDir =` | ||
|
|
||
| Alternatively you can simply set `bundleInDebug: true` in your app/build.gradle file, inside the `project.ext.react` map. |
Co-Authored-By: Michał Pierzchała <thymikee@gmail.com>
Contributor
Author
|
Emphasized the simpler way and added the details |
thymikee
approved these changes
Sep 10, 2019
thymikee
changed the title
thymikee
changed the title
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan: