doctor: improve ios-deploy installation
#726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
September 11, 2019 14:27
…into refactor/separate-cocoapods-installation
Member
Author
|
@thib92: if you have time, please take a look 🙂 |
thib92
reviewed
Sep 17, 2019
Contributor
thib92
left a comment
thib92
left a comment
There was a problem hiding this comment.
Looks good to me, just a couple things.
thib92
approved these changes
Sep 17, 2019
lucasbento
changed the base branch from
refactor/separate-cocoapods-installation
to
master
thymikee
reviewed
Sep 18, 2019
Member
Author
|
@thymikee: thanks for the review, changes done! |
thymikee
reviewed
Sep 18, 2019
Closed
thymikee
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR is related to #694, it improves the experience of when the command can not "guess" which package manager to use when installing
ios-deploy, with this change, we try to guess, if not available then we prompt a question asking which package manager to use (yarnornpm) and an option to skip, if the user chooses skip then we just print a message for manual installation.Before (when it couldn't guess the package manager)
After
When it guesses the package manager
When it shows options
When you choose "skip"
➡️ Skipping doesn't cancel the other health checks, it continues normally.
Test Plan:
yarn global remove ios-deploy/npm uninstall -g ios-deploy/path/to/cli doctorF