doctor: only show fix options if there are errors or warnings #729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasbento
changed the title
Closed
thymikee
reviewed
Sep 18, 2019
lucasbento
force-pushed
the
feature/doctor-hide-options-if-all-good
branch
from
db37693 to
0c932f1
Compare
thymikee
approved these changes
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR is related to #694, currently the usage section shows even if you have everything correct when running
doctor, with this change this will no longer happen.Test Plan:
path/to/cli doctor --fix(make sure that everything is green)path/to/cli doctor- no usage should show up and the process should be terminated successfully