propagate react-native config error stream to logs #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use output of subprocess in gradle file instead of input
generalpiston
requested review from
Esemesek,
grabbou and
thymikee
as code owners
thymikee
reviewed
Sep 22, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
It turns out that node was throwing an exception. The environment of the groovy process was using a version of node that I was not. @thymikee Let's pipe the contents of the error stream to the parent process instead? |
generalpiston
changed the title
generalpiston
changed the title
thymikee
approved these changes
Sep 26, 2019
Salakar
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use output of subprocess in gradle file instead of input
Summary:
See #740.
Test Plan:
Android Studio synchronizes.