fix: jsAppDir on Windows #850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @miginmrs can you verify? |
thymikee
referenced
this pull request
Nov 15, 2019
* feat: run npx from JS app dir * improve comment * use .sourceFile * extract getCommandOutput * better errors * apply feedback
thymikee
force-pushed
the
fix/windows-jsappdir
branch
from
e6a4909 to
41f7e25
Compare
thymikee
force-pushed
the
fix/windows-jsappdir
branch
from
41f7e25 to
cea5f2e
Compare
Member
|
With the tests failing, how one should verify that? |
Member
Author
|
Tests don't run Android code, only init. You'll need a Windows machine, yarn link packages and run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Apparently Gradle returns backslashes on windows for
buildscript.sourceFile.toString(): a3a70a1#r35970970. We need to account for thatTest Plan:
Both are supported: