fix: update Xcode version range to >= 10; change wording of supported version #856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasbento
requested review from
Esemesek,
grabbou and
thymikee
as code owners
thymikee
reviewed
Nov 19, 2019
thymikee
approved these changes
Nov 19, 2019
thymikee
changed the title
thymikee
reviewed
Nov 19, 2019
| `- Minimum version required: ${chalk.green(cleanedVersionRange)}`, | ||
| ); | ||
| logMessage(`- Version found: ${chalk.red(versionToShow)}`); | ||
| logMessage(`- Version supported: ${chalk.green(versionRange)}`); |
Member
There was a problem hiding this comment.
We can show the version range instead of semver coerced version. Here's a sample output how it looks now:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes an issue with Xcode being shown as
Minimum required version: 10.0.0even though we officially support11.x.This issue has been reported through https://twitter.com/chakrihacker/status/1196750533224091648.