Skip to content

Conversation

@rickhanlonii
Copy link
Collaborator

Summary:

Upgrades to Metro 0.58.0 which includes code frames for LogBox.

Also closes #922

Test Plan:

Tested in RNTester and confirmed that codeframes work in LogBox:

Screen Shot 2020-01-30 at 4 06 39 PM

@thymikee
Copy link
Member

@grabbou can you test if this works with RN 0.61 as well? It would be amazing if it did, because we could then use cli@3.x for both 0.61 and 0.62

@rickhanlonii
Copy link
Collaborator Author

Yeah it seems to work in 0.61 as well

@grabbou
Copy link
Member

grabbou commented Jan 31, 2020

Awesome! Let's ship it to 0.61 and 0.62 users via 3.x.

@grabbou grabbou merged commit e496c2a into react-native-community:master Jan 31, 2020
@rickhanlonii rickhanlonii deleted the rh-upgrade-metro branch February 5, 2020 11:25
grabbou pushed a commit that referenced this pull request Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade metro to v0.58.0 (fix inherited mem vulnerability)

3 participants