fix: added quotes for run instructions #981
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When initializing a project in a folder with spaces in the name, the commandline output showed a command which is not working for these folders. In general it is not recommended to create folders with spaces but in a Windows Environment it is quite common e.g. if the username is "John Doe" and you want to initialize a react-native project in a subfolder of the home directory.
To provide a working command id added quotes around the projectDir variable, so the command can be Copy & Pasted.
Test Plan:
mkdir "my repositories"cd "my repositories"react-native init testproject[...]
cd /home/johndoe/my repositories/testproject && npx react-native run-android-bash: cd: too many argumentsWith this Pull Request the project directory is surrounded by quotes and a copy & paste of the command will work.