Skip to content

iOS implementation - #28

Merged
ferrannp merged 47 commits into
callstack:2.0from
troZee:feature/ios-implementation
Jul 15, 2019
Merged

iOS implementation#28
ferrannp merged 47 commits into
callstack:2.0from
troZee:feature/ios-implementation

Conversation

@troZee

@troZee troZee commented May 20, 2019 •
edited by ferrannp
Loading

Copy link
Copy Markdown
Collaborator

Closes #24.

  • create iOS component
  • implement initialPage property
  • Implement scroll enabled
  • Implement page margin property
  • Update example

@troZee

troZee commented May 20, 2019

Copy link
Copy Markdown
Collaborator Author

cc @dratwas @ferrannp

@ferrannp
ferrannp requested review from dratwas and ferrannp May 20, 2019 10:26
dratwas
dratwas suggested changes May 21, 2019
View reviewed changes
Comment thread example/ios/ViewPagerExample.xcodeproj/project.pbxproj Outdated
Comment thread example/ios/ViewPagerExample.xcodeproj/project.pbxproj
Comment thread example/ios/ViewPagerExample.xcodeproj/project.pbxproj
Comment thread example/ios/ViewPagerExample.xcodeproj/project.pbxproj Outdated
Comment thread example/ios/ViewPagerExample.xcodeproj/project.pbxproj Outdated
Comment thread example/src/component/LikeCount.js Outdated
Comment thread example/src/component/LikeCount.js Outdated
Comment thread example/src/component/LikeCount.js Outdated
Comment thread ios/RNCViewpager.h Outdated
Comment thread ios/RNCViewpager.xcodeproj/project.pbxproj
@ferrannp ferrannp mentioned this pull request May 21, 2019
Closed
dratwas
dratwas suggested changes May 23, 2019
View reviewed changes
Comment thread ios/ReactNativePageView.m Outdated
Comment thread ios/ReactNativePageView.m Outdated
Comment thread ios/ReactNativePageView.m Outdated
Comment thread ios/ReactViewPagerManager.m Outdated
Comment thread ios/ReactNativePageView.m Outdated
Comment thread js/ViewPagerAndroid.ios.js Outdated
Comment thread js/ViewPagerAndroid.ios.js Outdated
Comment thread js/ViewPagerAndroid.ios.js
Comment thread js/ViewPagerAndroid.ios.js Outdated
Comment thread js/ViewPagerAndroid.ios.js Outdated
@ferrannp ferrannp added the wip Work In Progress label May 30, 2019
@erhanbicer

erhanbicer commented Jun 17, 2019

Copy link
Copy Markdown

When will ios support come? @ferrannp @dratwas @PTROCKI

@ferrannp

ferrannp commented Jun 17, 2019

Copy link
Copy Markdown
Contributor

@erhanbicer we had an internal meeting for this PR and there are still bugs and things that need to be done before merging so... It is still work in progress. I don't really have a date but we are looking into it.

@dratwas

dratwas commented Jun 17, 2019

Copy link
Copy Markdown

@erhanbicer
I did some fixes and hopefully the iOS implementation will land soon :)

@dratwas
dratwas requested review from dratwas and ferrannp June 17, 2019 19:52
@ferrannp
ferrannp changed the base branch from master to 2.0 June 18, 2019 11:44
@artechventure

artechventure commented Jul 11, 2019

Copy link
Copy Markdown

Any updates? I'm really looking forward to use this PR 🙏🏻

@ferrannp
ferrannp merged commit b54aa36 into callstack:2.0 Jul 15, 2019
@lucasmotta

lucasmotta commented Jul 17, 2019

Copy link
Copy Markdown

Hey @ferrannp, do you have any estimates of when version 2 will be released? Is it safe to use the 2.0 branch in prod?

@ferrannp

ferrannp commented Jul 18, 2019

Copy link
Copy Markdown
Contributor

We want to have some docs and check we did not miss anything before releasing. We plan to do this next week. It would be nice if some people like you try the branch and let us know if it works ok for you!

@KingAmo

KingAmo commented Sep 14, 2019

Copy link
Copy Markdown

any update on this PR ？ looking forward to it..

ferrannp pushed a commit that referenced this pull request Oct 4, 2019
@PTROCKI @ferrannp
feat: iOS implementation (#28)
e4fed74
osdnk
osdnk reviewed Mar 24, 2020
View reviewed changes
Comment thread ios/ReactNativePageView.m
}
_childrenViewControllers = tempChildrenViewControllers;
_reactPageIndicatorView.numberOfPages = _childrenViewControllers.count;
[self goTo:[NSNumber numberWithInteger:_currentIndex] animated:NO];

@osdnk osdnk Mar 24, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@osdnk osdnk osdnk left review comments
@ferrannp ferrannp ferrannp approved these changes
@dratwas dratwas dratwas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

wip Work In Progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@troZee @guhungry @erhanbicer @ferrannp @dratwas @artechventure @lucasmotta @KingAmo @osdnk