Remove sourceURL(for:) override — superseded by bundleURL() in new architecture#222
Open
christophpurrer wants to merge 1 commit into
Conversation
…acy arch removal The sourceURLForBridge: method will be removed from RCTBridgeDelegate in facebook/react-native#56831 due to the RCT_REMOVE_LEGACY_ARCH clean up. Then the override no longer overrides anything and fails Swift compilation. bundleURL() — already present below — is the replacement API on RCTReactNativeFactoryDelegate. This change depends on facebook/react-native#56974
Author
|
CC: @cortinico / @cipolleschi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove sourceURL(for:) override — superseded by bundleURL() in new architecture
Summary:
The sourceURLForBridge: method will be removed from RCTBridgeDelegate in facebook/react-native#56831 due to the RCT_REMOVE_LEGACY_ARCH clean up. Then the override no longer overrides anything and fails Swift compilation. bundleURL() — already present below — is the replacement API on RCTReactNativeFactoryDelegate. This change depends on facebook/react-native#56974
Changelog:
[IOS][FIXED] Remove legacy architecture sourceURLForBridge from template/ios/HelloWorld/AppDelegate.swift
Test Plan:
CI