[iOS] Pass the RCTAppDependencyProvider to the RCTAppDelegate #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakef
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We recently inverted the dependency between
ReactCodegenandReact-RCTAppDelegate, so that now the Codegen depends on the AppDelegate.Remember that
ReactCodegenis generated when the user runpod install, while the RCTAppDelegate exists in React Native, so the new dependency is more correct and enables prebuilds for iOS.For that reason, we need to make sure that the App passes to React Native the dependency provider before React Native is started.
Changelog:
[iOS][Breaking] - Pass the dependency provider from the App to React Native.
Test Plan:
Tested locally in a nightly.