fix: Update RNDateTimePickerComponentView to import cpp relatively #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@vonovak here's the change to imports we talked about |
vonovak
pushed a commit
that referenced
this pull request
Sep 30, 2022
## [6.4.2](v6.4.1...v6.4.2) (2022-09-30) ### Bug Fixes * Update RNDateTimePickerComponentView to import cpp relatively ([#670](#670)) ([45e3a5e](45e3a5e))
Member
|
🎉 This issue has been resolved in version 6.4.2 🎉 If this package helps you, consider sponsoring us! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since we removed the cpp subspec with the
rndatetimepickerheader dir and moved cpp inside theiosdir, it makes sense to change theComponentDescriptors.himport inRNDateTimePickerComponentView.mmto a relative path.Test Plan
Run the app in fabric and it builds. It wouldn't build if the import was not found.
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdexample/App.js)