fix: improve typings for native module error #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

vonovak merged 1 commit into master from fix/improve-error-handling

Oct 3, 2021

+29 −11

Member

vonovak commented Oct 3, 2021 •

edited

Loading

Summary

TS handles catch() block errors as unknown and we should follow that approach.

Test Plan

TS does not complain in example app

Compatibility

OS	Implemented
iOS	✅
Android	✅

Checklist

I have tested this on a device and a simulator
I added the documentation in README.md
I updated the typed files (TS and Flow)


          fix: improve typings for native module error

f8b0103

vonovak merged commit 70338a8 into master

vonovak deleted the fix/improve-error-handling branch

October 3, 2021 07:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet