-
Notifications
You must be signed in to change notification settings - Fork 709
Add support for Fabric renderer (new architecture) #621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Fabric renderer (new architecture) #621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the code, but I'm not that familiar with the codebase nor Fabric.
But I tested both iOS and Android on react-native 0.72.3. No issues.
|
@hsjoberg - Thanks a lot for taking time for the review and testing. I will also do some additional testing this weekend, and hopefully we'll have a first prerelease ready by next week. |
|
@friederbluemle do you have an updated timeline on this one? |
|
@shikharmohan - You can expect an initial alpha version for testing in the next couple of days! |
Nice, does alpha version mean that you can download it with npm? |
Yes, you will be able to use npm, but the |
608eb07 to
a96b913
Compare
|
@hsjoberg @shikharmohan @mvpdsolutions @WadhahEssam - This PR has been merged and published as https://github.com/react-native-linear-gradient/react-native-linear-gradient/releases/tag/v3.0.0-alpha.0 When you have a chance please test and report any issues.
In order to test this new prerelease, use the following commands: Yarn npm npm i react-native-linear-gradient@next |
Hi @friederbluemle, |
This PR contains the remaining code changes to enable the Fabric renderer (React Native New Architecture).
A prerequisite PR (#608) has already been merged. The changes also contain the re-applied patch from #604 which is a requirement but needed to be reverted temporarily (see #613).
The example app has been upgraded to React Native 0.70 to allow testing with the new architecture in #606
The rest of the steps are broken up into logical and easy to review commits.
Shout out and big thanks to @Sunbreak who contributed major work (I kept Sunbreak as the commit author for two of the commits).
After some more testing and external verification, we can hopefully get this PR merged very soon. 🤞
In order to run the example app using new architecture, follow these steps (after the usual Yarn dependency installation etc), in the
example/folder:Android
iOS
This PR also updates CI workflows and splits the two
build-androidandbuild-iosjobs into two separate-oldarch/-newarchjobs each, to test the build with and without the new architecture enabled. The jobs will run in parallel, so it will take almost the same amount of time.Closes #552
Closes #575
Closes #593
Closes #622
Testing Overview