`image` not visible without setting `imageColor`

[areknow]

Without setting an image color, it appears that the icon does not render:

const USER_MENU: MenuAction[] = [
  {
    id: "add",
    title: "Add",
    image: "plus",
    // imageColor: "black",
  },
];

After setting a color:

const USER_MENU: MenuAction[] = [
  {
    id: "add",
    title: "Add",
    image: "plus",
    imageColor: "black",
  },
];

I believe this may be due to the new architecture migration. In an older project of mine, I do not have the above issue.

[teaualune]

I've ran into this issue on new arch as well

After investigation, this is due to a value unboxing issue: in ios/Shared/RCTMenuItem.swift line 35,

if let imageColor = details["imageColor"] {

If you don't provide imageColor on the JS side, the imageColor value here will be resolved to 0, thus the image will be converted with RCTConvert.uiColor(0)

To solve this issue temporarily I add a small patch that rewrites line 35 into:

if let imageColor = details["imageColor"], (imageColor as? Int) != 0 {

Although this didn't solve the actual issue, just a workaround.

[tmoran-stenoa]

Thank you @teaualune, your patch worked for me.