fix(iOS): Ensure all calls to isConnected.fetch resolve #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-oakes
force-pushed
the
fix-issue-10
branch
from
50f9d41 to
fc5125d
Compare
matt-oakes
force-pushed
the
fix-issue-10
branch
from
fc5125d to
ad6255d
Compare
Salakar
approved these changes
Feb 20, 2019
|
🎉 This PR is included in version 1.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced May 28, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where multiple calls to
isConnected.fetchwould only resolve the final one on iOS. It would correctly resolve them on Android.The fix was was keep a copy of all of the resolvers, not just the last one, in an NSSet. We can then call them all when the connection data comes back.
I have also added an e2e test case to test this behaviour. We need to wait for #14 to be merged in before this is ready to do. I'm opening a fancy new "draft" PR now so it's here.
Fixes #10.