Skip to content

chore: use community eslint config #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cpojer merged 1 commit into from
Jan 3, 2020
Merged

chore: use community eslint config #19

cpojer merged 1 commit into from
Jan 3, 2020

Conversation

@Naturalclar
Copy link
Member

@Naturalclar Naturalclar commented Dec 29, 2019 •
edited
Loading

Overview

This PR closes #12 and #13

Configured to use community eslint config, and modified circleci config to run lint check

Test Plan

  • yarn lint
  • yarn flow
  • circle ci

cpojer
cpojer approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cpojer cpojer merged commit 60fdb7f into react-native-segmented-control:master Jan 3, 2020
@Naturalclar Naturalclar mentioned this pull request Jan 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cpojer cpojer cpojer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Setup CircleCI

2 participants

@Naturalclar @cpojer