Adding postMessage support to the webview. #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minishlink
reviewed
Jul 31, 2018
Member
Minishlink
left a comment
Minishlink
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Can you change the strategy as stated in the code comments please?
src/index.js
Outdated
| const { title, source, onLoad, scrollEnabled } = this.props; | ||
| const styleObj = StyleSheet.flatten(this.props.style); | ||
| return createElement('iframe', { | ||
| let contentFrame = createElement('iframe', { |
Member
There was a problem hiding this comment.
Please keep return createElement (you don't need contentFrame afterwards)
src/index.js
Outdated
| return createElement('iframe', { | ||
| let contentFrame = createElement('iframe', { | ||
| title, | ||
| id: elementId, |
Member
There was a problem hiding this comment.
Please use a DOM ref on the iframe and don't rely on this elementId
…ed. Ref used on iframe and postMessage is called on ref rather than using element id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added postMessage support to the webview component.