This repository was archived by the owner on Feb 25, 2020. It is now read-only.
Use react-is to check valid components#10
Merged
ericvicenti merged 1 commit intoreact-navigation:masterfrom Oct 19, 2018
Merged
Use react-is to check valid components#10ericvicenti merged 1 commit intoreact-navigation:masterfrom
ericvicenti merged 1 commit intoreact-navigation:masterfrom
Conversation
satya164
approved these changes
Oct 19, 2018
Contributor
|
Looks great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current checks do not work when using things like React.forwardRef. This fixes it by using the react-is package that is made for those checks.
Tested that is works with React.forwardRef components and still fails on invalid components.