update withNavigation doc #353
Conversation
|
Deploy preview for react-navigation ready! Built with commit a76ecea |
|
hi! Thanks for the PR, can you please make the same change in the versioned docs too, as explained in the PR template? Thanks. |
|
@vonovak I've checked it and I do not see that another file has to update. |
|
@bySabi does this explanation help? https://github.com/react-navigation/react-navigation.github.io/blob/source/.github/PULL_REQUEST_TEMPLATE.md |
|
@bySabi does this explanation help? https://github.com/react-navigation/react-navigation.github.io/blob/source/.github/PULL_REQUEST_TEMPLATE.md I hope so :-) |
|
it seems that in the end I did not catch it :-) |
| <MyBackButton onRef={(elem) => this.backButton = elem} /> | ||
| ``` | ||
|
|
||
| - If you need to use `withNavigation` HOC as the wrapped component of a custom HOC that use `onRef` prop API too, in order to prevent `onRef` callback fuction be called twice, `onRef` injectiong must be disabled using second param `config` object. |
There was a problem hiding this comment.
After reading this over, I think this paragraph should have ### Config heading, with a clear listing of what the config object can contain (even though there is just one option available - this is a the api reference: kinda like here). Does this make sense?
| @@ -0,0 +1,4 @@ | |||
| # THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. | |||
| # yarn lockfile v1 | |||
There was a problem hiding this comment.
can you please remove this file?
|
Closing due to no response. |
4 participants
Updating
docfor reflect API changes introduced on PR: react-navigation/core#30 (comment)