fix: add flex: 1 to DrawerItem style#8701
Merged
satya164 merged 1 commit intoreact-navigation:mainfrom Sep 2, 2020
Merged
Conversation
|
Deploy preview for react-navigation-example ready! Built with commit 28b0376 https://deploy-preview-8701--react-navigation-example.netlify.app |
|
Was just coming here to add this! When will this be released please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the DrawerItem, It's not possible to provide style for the label wrapper, only for the label, so the label wrapper must at least be
flex: 1in order to be more flexible for custom components, like in the pictures below.In the below examples, providing
flex: 1inside the custom component view is not enough, because the wrapper does not grow. This PR will fix it.An alternative would be creating a new prop
labelStyleWrapper, but I don't see any motivation for doing so, as this PR would fix it.Before
After