Peer dependencies

[nickpisacane]

Awesome work on react-toolbox!
This example helped me get started quickly. I added node-sass, normalize.css, and react-addons-css-transition-group to devDependenices in package.json (webpack build was failing with out them), and README.md with some simple instructions. I figured for people using npm v3+ it would be useful to include the peerDependencies, as npm won't install them automatically.

[javivelasco]

Thanks for your words! :)

Normalize should come as a dependency from Toolbox. The commons.scss includes normalize, it's failing the build without it for you? node-sass is ok there I think

[vyorkin]

@javivelasco yes, its failing without normalize.css, I've just tried to add only node-sass & react-addons-css-transition-group to devDependencies:

ERROR in ./app/style.scss
Module build failed: ModuleNotFoundError: Module not found: Error: Cannot resolve module '~normalize.css' in /Users/vyorkin/github/react-toolbox-example/app
    at Compilation.<anonymous> (/Users/vyorkin/github/react-toolbox-example/node_modules/webpack/lib/Compilation.js:228:38)

I'm on npm v3.3.6, it doesn't install peerDependencies.

[nickpisacane]

Yes the initial build fails without node-sass, and normalize.css for anyone using npm 3.0+, as peerDependencies will not be installed automatically. npm will warn the user of unmet peerDependencies, which I think is fine an npm installation. However, I think it would be useful for the example to include the peerDependencies as a devDependencies so people can simply clone, install, and run, regardless of which npm version is installed.

Here is the output after running npm i (npm v3.3.6)

npm WARN EPEERINVALID sass-loader@3.1.1 requires a peer of node-sass@^3.3.3 but none was installed.
npm WARN EPEERINVALID react-toolbox@0.11.3 requires a peer of react-addons-css-transition-group@^0.14.0 but none was installed.
npm WARN EPEERINVALID react-toolbox@0.11.3 requires a peer of normalize.css@^3.0.3 but none was installed.

On Ubuntu 15.04, the build failed without react-addons-css-transition-group, but did not on OSX. Currently, I'm trying to get to the bottom of that.

Thanks for looking into this!

[javivelasco]

I see. I'm ok with that, merged!
Thanks!