Skip to content

[Android] fix: network call timeout #38953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
troZee wants to merge 2 commits into from
Closed

[Android] fix: network call timeout #38953

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11e55b6
fix: network call timeout
Aug 11, 2023
517fee6
Merge branch 'facebook:main' into fix/network-timeout
troZee Aug 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ative/ReactAndroid/src/main/java/com/facebook/react/modules/network/NetworkingModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ public void onProgress(
// shared under the hood.
// See https://github.com/square/okhttp/wiki/Recipes#per-call-configuration for more information
if (timeout != mClient.connectTimeoutMillis()) {

@NickGerleman NickGerleman Aug 16, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is no longer correct (should be callTimeoutMillis()). I can fix it up quickly.

@Marco29001 Marco29001 Oct 2, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how change this line?

clientBuilder.connectTimeout(timeout, TimeUnit.MILLISECONDS);
clientBuilder.callTimeout(timeout, TimeUnit.MILLISECONDS);
}
OkHttpClient client = clientBuilder.build();

Expand Down