Improve e2e times by using deep links to open examples#51786
Closed
mateoguzmana wants to merge 1 commit into
Closed
Improve e2e times by using deep links to open examples#51786mateoguzmana wants to merge 1 commit into
mateoguzmana wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
mateoguzmana
force-pushed
the
e2e/deeplink-to-improve-speed-time
branch
from
5bb0895 to
8b1d0f7
Compare
facebook-github-bot
added
the
Shared with Meta
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cortinico merged this pull request in 8960d9e. |
Collaborator
|
This pull request was successfully merged by @mateoguzmana in 8960d9e When will my fix make it into a release? | How to file a pick request? |
Contributor
|
this fully broke the E2E tests for iOS in CI... :( |
Contributor
|
@mateoguzmana we had to revert this as it broke the CI test |
Collaborator
Author
|
Oh, that's annoying :( – sorry for the trouble, folks. Will check if the CI issue is reproducible and try to land it with a fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is similar to #51590, but way better as it improves indirectly the flakiness for tests in the API tab. When the logbox is shown in debug mode, it interferes and sometimes makes that test fail, so this prevents that.
Android also takes more advantage of the improvement with this change, the previous PR only improved significantly iOS.
All the screens inside the RNTester seem to have a deeplink, which makes it easier to open the tests as the test cases are intended to check mostly specific behaviour of RN, and it is not necessary to have a middle step to find the specific components.
Maybe it would be good to run this a few times in CI to see if there are no side effects or flakiness added by opening deep links on CI builds.
Changelog:
[INTERNAL] - Improve e2e times by using deep links to open examples
Test Plan:
iOS:
Android: