Don't prefetch Android res images with int ids#53493
Closed
christophpurrer wants to merge 2 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81200872 |
christophpurrer
force-pushed
the
export-D81200872
branch
from
021932f to
1aa62d5
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81200872 |
christophpurrer
force-pushed
the
export-D81200872
branch
from
1aa62d5 to
0c69d49
Compare
christophpurrer
force-pushed
the
export-D81200872
branch
from
0c69d49 to
0b7ea1e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81200872 |
christophpurrer
force-pushed
the
export-D81200872
branch
from
0b7ea1e to
c5ba349
Compare
christophpurrer
force-pushed
the
export-D81200872
branch
from
c5ba349 to
e9154e8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81200872 |
christophpurrer
force-pushed
the
export-D81200872
branch
from
e9154e8 to
8657abf
Compare
Summary: Changelog: [Internal] Sending individual image prefetch request on Android over JNI is causing measurable performance regression. The idea here is batch all image prefetch request for a given shadowNodeTree and then flush it all at once - **DONE** in the next change. Another optimization we should consider is to execute the batch on `n imagePrefetchRequest` off the JavaScript thread `mqt_v_js` and instead on e.g. the UiThread (on which currently Android Image UI initiates image resource downloads) Reviewed By: lenaic Differential Revision: D81186916
Summary: Changelog: [Internal] Don't prefetch local images shipped with the app Reviewed By: lenaic Differential Revision: D81200872
christophpurrer
force-pushed
the
export-D81200872
branch
from
8657abf to
29aeaed
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81200872 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Aug 29, 2025
Summary: Changelog: [Internal] Don't prefetch local images shipped with the app Reviewed By: lenaic Differential Revision: D81200872
Contributor
|
This pull request has been merged in 5858c83. |
Collaborator
|
This pull request was successfully merged by @christophpurrer in 5858c83 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Don't prefetch local images shipped with the app
Differential Revision: D81200872