Rename TypeInformationComparisonError fields to match TypeAnnotationComparisonError#55302
Closed
elicwhite wants to merge 2 commits into
Closed
Rename TypeInformationComparisonError fields to match TypeAnnotationComparisonError#55302elicwhite wants to merge 2 commits into
elicwhite wants to merge 2 commits into
Conversation
Summary: Replace the brief CONTRIBUTING.md with a comprehensive AGENTS.md that provides AI coding assistants with detailed guidance for working with the react-native-compatibility-check package. The new documentation covers the three-stage pipeline architecture, compatibility rules, testing patterns, and design principles that were previously only partially documented. Changelog: [Internal] Reviewed By: makovkastar Differential Revision: D91275922
…omparisonError Summary: Rename newerType/olderType to newerAnnotation/olderAnnotation in TypeInformationComparisonError to be consistent with TypeAnnotationComparisonError. This allows code that handles both error types to access annotation fields uniformly without checking error type first. Changelog: [Internal] Reviewed By: makovkastar Differential Revision: D91275947
meta-cla
Bot
added
the
CLA Signed
|
@elicwhite has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91275947. |
|
This pull request has been merged in 1575ae0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Rename newerType/olderType to newerAnnotation/olderAnnotation in TypeInformationComparisonError to be consistent with TypeAnnotationComparisonError. This allows code that handles both error types to access annotation fields uniformly without checking error type first.
Changelog: [Internal]
Reviewed By: makovkastar
Differential Revision: D91275947