Add @DoNotStripAny to AnimationBackendChoreographer#55465
Closed
mdvacca wants to merge 1 commit into
Closed
Conversation
Summary: - AnimationBackendChoreographer.resume() and pause() are called from C++ via JNI reflection in JAnimationBackendChoreographer.cpp, but the class had no ProGuard/R8 protection annotation - R8 renames the methods during minification, causing NoSuchMethodError at runtime when JNI looks up "resume" by name - Every other JNI-accessed class in the fabric package (FabricUIManager, ComponentFactory, StateWrapperImpl, EventEmitterWrapper, EventBeatManager, MountItem) already uses DoNotStripAny — this was the only one missing changelog: [internal] internal Reviewed By: fkgozali Differential Revision: D92628923
meta-cla
Bot
added
the
CLA Signed
Collaborator
|
This pull request was successfully merged by @mdvacca in 0dd9e73 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 0dd9e73. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
JNI reflection in JAnimationBackendChoreographer.cpp, but the class had no
ProGuard/R8 protection annotation
runtime when JNI looks up "resume" by name
ComponentFactory, StateWrapperImpl, EventEmitterWrapper, EventBeatManager,
MountItem) already uses DoNotStripAny — this was the only one missing
changelog: [internal] internal
Reviewed By: fkgozali
Differential Revision: D92628923