Fix "instrinsic" typo in function name to "intrinsic"#1928
Closed
J8118 wants to merge 1 commit into
Closed
Conversation
Rename instrinsicSizeMeasureFunc -> intrinsicSizeMeasureFunc across the source definition (utils.ts), the test generator (JavascriptEmitter.ts), and all generated test files.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
facebook-github-tools
Bot
added
the
Shared with Meta
|
@fabriziocucci has imported this pull request. If you are a Meta employee, you can view this in D100144238. |
cortinico
approved these changes
Apr 9, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
@fabriziocucci merged this pull request in fb8e618. |
J8118
added a commit
to J8118/yoga
that referenced
this pull request
Apr 9, 2026
Fix "instrinsic" typo in function name to "intrinsic" (react#1928)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function
instrinsicSizeMeasureFuncis misspelled — "instrinsic" should be "intrinsic". This typo originated in the utility function definition and was propagated by the test generator to all generated test files.Files changed:
javascript/tests/tools/utils.ts— function definition (source of truth)gentest/src/emitters/JavascriptEmitter.ts— generator that emits the import and usagejavascript/tests/generated/— updated to matchTest plan