refactor(select): improve keyboard and events #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… correctly Code coverage depends on TypeScript sourceMap, which we disabled for builds.
WesSouza
force-pushed
the
refactor/wes/select-improved
branch
from
c04f8ca to
4903539
Compare
… if value is set without onChange or readOnly
WesSouza
force-pushed
the
refactor/wes/select-improved
branch
from
4903539 to
5c18b21
Compare
WesSouza
force-pushed
the
refactor/wes/select-improved
branch
from
5c18b21 to
282ac81
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4bceb5a:
|
…Native BREAKING CHANGE: Select props changed significantly, native is now the SelectNative component
WesSouza
force-pushed
the
refactor/wes/select-improved
branch
from
282ac81 to
4bceb5a
Compare
WesSouza
changed the title
arturbien
approved these changes
Sep 10, 2022
|
🎉 This PR is included in version 4.0.0-beta.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress for Select component refactor:
<Select native>to<SelectNative>SelectintouseSelectStatehook (only used by Select)useSelectCommon(used by both selects)onChangecallback to pass selected option as the first argument{ fromEvent: Event | React.SyntheticEvent }as the last argument (onOpen,onClose,onChange)StyledInnercomponent instead ofinput(replacesSelectDisplayPropsprop)inputPropsto allow spreading of props on theinputelementlabelIdin favor ofaria-labelledbyI've also changed the Select story to list all Pokémon, so typing can be tested.
Storybook