Skip to content

Fix: Use correct syntax for options props for line chart example #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dangreen merged 1 commit into from
Oct 18, 2021
Merged

Fix: Use correct syntax for options props for line chart example #744

dangreen merged 1 commit into from
Oct 18, 2021

Conversation

@Tomastomaslol
Copy link
Contributor

@Tomastomaslol Tomastomaslol commented Oct 6, 2021

  • Use updated syntax to set beginAtZero for y-axis for line chart example

After change
Screen Shot 2021-10-06 at 4 27 09 pm

Before change
Screen Shot 2021-10-06 at 4 28 10 pm

@dangreen dangreen self-requested a review October 15, 2021 10:26
@dangreen dangreen merged commit 9c83941 into reactchartjs:master Oct 18, 2021
@dangreen
Copy link
Collaborator

dangreen commented Oct 18, 2021

@Tomastomaslol Thanks for your contribution!

@Tomastomaslol Tomastomaslol deleted the fix-line-chart-example branch October 18, 2021 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dangreen dangreen dangreen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Tomastomaslol @dangreen