Skip to content

fix: runtimes should be nodejs instead of nodejx #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buggy merged 1 commit into from
Dec 25, 2024
Merged

fix: runtimes should be nodejs instead of nodejx #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 25 additions & 25 deletions src/__tests__/__snapshots__/entryFor.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ exports[`Function CodeUri can be set at the function 1`] = `
"Properties": {
"CodeUri": "MyLambda",
"Handler": "app.handler",
"Runtime": "nodejx18.x",
"Runtime": "nodejs22.x",
},
"Type": "AWS::Serverless::Function",
},
Expand Down Expand Up @@ -96,7 +96,7 @@ exports[`Function CodeUri can be set global or at the function 1`] = `
"Properties": {
"CodeUri": "MyLambda",
"Handler": "app.handler",
"Runtime": "nodejx18.x",
"Runtime": "nodejs22.x",
},
"Type": "AWS::Serverless::Function",
},
Expand Down Expand Up @@ -153,7 +153,7 @@ exports[`Function CodeUri can be set globally 1`] = `
"Properties": {
"CodeUri": "MyLambda",
"Handler": "app.handler",
"Runtime": "nodejx18.x",
"Runtime": "nodejs22.x",
},
"Type": "AWS::Serverless::Function",
},
Expand Down Expand Up @@ -205,7 +205,7 @@ exports[`Function Handler can be set at the function 1`] = `
"Properties": {
"CodeUri": "MyLambda",
"Handler": "app.handler",
"Runtime": "nodejx18.x",
"Runtime": "nodejs22.x",
},
"Type": "AWS::Serverless::Function",
},
Expand Down Expand Up @@ -262,7 +262,7 @@ exports[`Function Handler can be set global and at function 1`] = `
"Properties": {
"CodeUri": "MyLambda",
"Handler": "app.handler",
"Runtime": "nodejx18.x",
"Runtime": "nodejs22.x",
},
"Type": "AWS::Serverless::Function",
},
Expand Down Expand Up @@ -319,7 +319,7 @@ exports[`Function Handler can be set globally 1`] = `
"Properties": {
"CodeUri": "MyLambda",
"Handler": "app.handler",
"Runtime": "nodejx18.x",
"Runtime": "nodejs22.x",
},
"Type": "AWS::Serverless::Function",
},
Expand All @@ -332,7 +332,7 @@ exports[`Function Handler can be set globally 1`] = `
}
`;

exports[`Function Runtime can be set at the function to nodejx18.x 1`] = `
exports[`Function Runtime can be set at the function to nodejs18.x 1`] = `
{
"entryPoints": {
"MyLambda": "./src/my-lambda/app",
Expand Down Expand Up @@ -371,7 +371,7 @@ exports[`Function Runtime can be set at the function to nodejx18.x 1`] = `
"Properties": {
"CodeUri": "MyLambda",
"Handler": "app.handler",
"Runtime": "nodejx18.x",
"Runtime": "nodejs18.x",
},
"Type": "AWS::Serverless::Function",
},
Expand All @@ -384,7 +384,7 @@ exports[`Function Runtime can be set at the function to nodejx18.x 1`] = `
}
`;

exports[`Function Runtime can be set at the function to nodejx18.x 2`] = `
exports[`Function Runtime can be set at the function to nodejs20.x 1`] = `
{
"entryPoints": {
"MyLambda": "./src/my-lambda/app",
Expand Down Expand Up @@ -423,7 +423,7 @@ exports[`Function Runtime can be set at the function to nodejx18.x 2`] = `
"Properties": {
"CodeUri": "MyLambda",
"Handler": "app.handler",
"Runtime": "nodejx18.x",
"Runtime": "nodejs20.x",
},
"Type": "AWS::Serverless::Function",
},
Expand All @@ -436,7 +436,7 @@ exports[`Function Runtime can be set at the function to nodejx18.x 2`] = `
}
`;

exports[`Function Runtime can be set at the function to nodejx20.x 1`] = `
exports[`Function Runtime can be set at the function to nodejs22.x 1`] = `
{
"entryPoints": {
"MyLambda": "./src/my-lambda/app",
Expand Down Expand Up @@ -475,7 +475,7 @@ exports[`Function Runtime can be set at the function to nodejx20.x 1`] = `
"Properties": {
"CodeUri": "MyLambda",
"Handler": "app.handler",
"Runtime": "nodejx20.x",
"Runtime": "nodejs22.x",
},
"Type": "AWS::Serverless::Function",
},
Expand Down Expand Up @@ -524,15 +524,15 @@ exports[`Function Runtime can be set global and at function 1`] = `
"AWSTemplateFormatVersion": "2010-09-09",
"Globals": {
"Function": {
"Runtime": "nodejx20.x",
"Runtime": "nodejs20.x",
},
},
"Resources": {
"MyLambda": {
"Properties": {
"CodeUri": "MyLambda",
"Handler": "app.handler",
"Runtime": "nodejx18.x",
"Runtime": "nodejs22.x",
},
"Type": "AWS::Serverless::Function",
},
Expand All @@ -545,7 +545,7 @@ exports[`Function Runtime can be set global and at function 1`] = `
}
`;

exports[`Function Runtime can be set globally to nodejx18.x 1`] = `
exports[`Function Runtime can be set globally to nodejs18.x 1`] = `
{
"entryPoints": {
"MyLambda": "./src/my-lambda/app",
Expand Down Expand Up @@ -581,7 +581,7 @@ exports[`Function Runtime can be set globally to nodejx18.x 1`] = `
"AWSTemplateFormatVersion": "2010-09-09",
"Globals": {
"Function": {
"Runtime": "nodejx18.x",
"Runtime": "nodejs18.x",
},
},
"Resources": {
Expand All @@ -601,7 +601,7 @@ exports[`Function Runtime can be set globally to nodejx18.x 1`] = `
}
`;

exports[`Function Runtime can be set globally to nodejx18.x 2`] = `
exports[`Function Runtime can be set globally to nodejs20.x 1`] = `
{
"entryPoints": {
"MyLambda": "./src/my-lambda/app",
Expand Down Expand Up @@ -637,7 +637,7 @@ exports[`Function Runtime can be set globally to nodejx18.x 2`] = `
"AWSTemplateFormatVersion": "2010-09-09",
"Globals": {
"Function": {
"Runtime": "nodejx18.x",
"Runtime": "nodejs20.x",
},
},
"Resources": {
Expand All @@ -657,7 +657,7 @@ exports[`Function Runtime can be set globally to nodejx18.x 2`] = `
}
`;

exports[`Function Runtime can be set globally to nodejx20.x 1`] = `
exports[`Function Runtime can be set globally to nodejs22.x 1`] = `
{
"entryPoints": {
"MyLambda": "./src/my-lambda/app",
Expand Down Expand Up @@ -693,7 +693,7 @@ exports[`Function Runtime can be set globally to nodejx20.x 1`] = `
"AWSTemplateFormatVersion": "2010-09-09",
"Globals": {
"Function": {
"Runtime": "nodejx20.x",
"Runtime": "nodejs22.x",
},
},
"Resources": {
Expand Down Expand Up @@ -755,7 +755,7 @@ exports[`It ignores non AWS::Serverless::Function resosurces 1`] = `
"Properties": {
"CodeUri": "MyLambda",
"Handler": "app.handler",
"Runtime": "nodejx18.x",
"Runtime": "nodejs22.x",
},
"Type": "AWS::Serverless::Function",
},
Expand Down Expand Up @@ -804,7 +804,7 @@ exports[`JS output files uses outFile parameter 1`] = `
"AWSTemplateFormatVersion": "2010-09-09",
"Globals": {
"Function": {
"Runtime": "nodejx18.x",
"Runtime": "nodejs22.x",
},
},
"Resources": {
Expand Down Expand Up @@ -860,7 +860,7 @@ exports[`When the template is in a subfolder it should match the happy snapshot
"AWSTemplateFormatVersion": "2010-09-09",
"Globals": {
"Function": {
"Runtime": "nodejx18.x",
"Runtime": "nodejs22.x",
},
},
"Resources": {
Expand Down Expand Up @@ -916,15 +916,15 @@ exports[`can be set global and at function 1`] = `
"AWSTemplateFormatVersion": "2010-09-09",
"Globals": {
"Function": {
"Runtime": "nodejx20.x",
"Runtime": "nodejs20.x",
},
},
"Resources": {
"MyLambda": {
"Properties": {
"CodeUri": "MyLambda",
"Handler": "app.handler",
"Runtime": "nodejx18.x",
"Runtime": "nodejs22.x",
},
"Type": "AWS::Serverless::Function",
},
Expand Down
18 changes: 9 additions & 9 deletions src/__tests__/__snapshots__/integration.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ exports[`Happy path with VS Code debugging disabled 1`] = `
Transform: AWS::Serverless-2016-10-31
Globals:
Function:
Runtime: nodejx18.x
Runtime: nodejs22.x
Resources:
MyLambda:
Type: AWS::Serverless::Function
Expand All @@ -32,7 +32,7 @@ exports[`Happy path with an output file specified 1`] = `
Transform: AWS::Serverless-2016-10-31
Globals:
Function:
Runtime: nodejx18.x
Runtime: nodejs22.x
Resources:
MyLambda:
Type: AWS::Serverless::Function
Expand Down Expand Up @@ -78,7 +78,7 @@ exports[`Happy path with default constructor works 1`] = `
Transform: AWS::Serverless-2016-10-31
Globals:
Function:
Runtime: nodejx18.x
Runtime: nodejs22.x
Resources:
MyLambda:
Type: AWS::Serverless::Function
Expand Down Expand Up @@ -124,7 +124,7 @@ exports[`Happy path with empty options in the constructor works 1`] = `
Transform: AWS::Serverless-2016-10-31
Globals:
Function:
Runtime: nodejx18.x
Runtime: nodejs22.x
Resources:
MyLambda:
Type: AWS::Serverless::Function
Expand Down Expand Up @@ -170,7 +170,7 @@ exports[`Happy path with empty options in the constructor works and an existing
Transform: AWS::Serverless-2016-10-31
Globals:
Function:
Runtime: nodejx18.x
Runtime: nodejs22.x
Resources:
MyLambda:
Type: AWS::Serverless::Function
Expand Down Expand Up @@ -260,7 +260,7 @@ exports[`Happy path with multiple projects and different template names works 1`
Transform: AWS::Serverless-2016-10-31
Globals:
Function:
Runtime: nodejx18.x
Runtime: nodejs22.x
Resources:
MyLambda:
Type: AWS::Serverless::Function
Expand All @@ -272,7 +272,7 @@ Resources:
Transform: AWS::Serverless-2016-10-31
Globals:
Function:
Runtime: nodejx18.x
Runtime: nodejs22.x
Resources:
MyLambda:
Type: AWS::Serverless::Function
Expand Down Expand Up @@ -338,7 +338,7 @@ exports[`Happy path with multiple projects works 1`] = `
Transform: AWS::Serverless-2016-10-31
Globals:
Function:
Runtime: nodejx18.x
Runtime: nodejs22.x
Resources:
MyLambda:
Type: AWS::Serverless::Function
Expand All @@ -350,7 +350,7 @@ Resources:
Transform: AWS::Serverless-2016-10-31
Globals:
Function:
Runtime: nodejx18.x
Runtime: nodejs22.x
Resources:
MyLambda:
Type: AWS::Serverless::Function
Expand Down
Loading