Implementation of About section [Fixes #78]#100
Merged
antosan merged 5 commits intoreactdeveloperske:developfrom Oct 22, 2022
Merged
Implementation of About section [Fixes #78]#100antosan merged 5 commits intoreactdeveloperske:developfrom
antosan merged 5 commits intoreactdeveloperske:developfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
antosan
requested changes
Oct 21, 2022
Member
antosan
left a comment
There was a problem hiding this comment.
@AJ-Kulundu Kindly make these adjustments:
-
1. Include the
AboutUscomponent in thesrc/pages/index.page.tsxpage. The AboutPage will be deleted in a future PR. -
2. Run
npm run prettier:formatto format the files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Closes #78
Implements the about section according to the designs for mobile viewports and desktop viewports.
Changes proposed
AboutUsthat implements the component shown on the designs.idofabout-us.index.page.tsxin theaboutfolder.Check List (Check all the applicable boxes)
Screenshots
Desktop and Tablet View

Mobile View

Note to reviewers
tsconfig.jsonto make it easier to import components into the pages.