Skip to content

Implementation of About section [Fixes #78]#100

Merged
antosan merged 5 commits intoreactdeveloperske:developfrom
AJ-Kulundu:about-section
Oct 22, 2022
Merged

Implementation of About section [Fixes #78]#100
antosan merged 5 commits intoreactdeveloperske:developfrom
AJ-Kulundu:about-section

Conversation

@AJ-Kulundu
Copy link
Copy Markdown
Contributor

Fixes Issue

Closes #78
Implements the about section according to the designs for mobile viewports and desktop viewports.

Changes proposed

  • Create a component named AboutUs that implements the component shown on the designs.
  • The section tag has an id of about-us.
  • Component was added to the index.page.tsx in the about folder.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Desktop and Tablet View
desk-about

Mobile View
mobile-about

Note to reviewers

  1. A paths directory should be added to the tsconfig.json to make it easier to import components into the pages.

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
reactdevske-website ✅ Ready (Inspect) Visit Preview Oct 22, 2022 at 8:28AM (UTC)

Copy link
Copy Markdown
Member

@antosan antosan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AJ-Kulundu Kindly make these adjustments:

  • 1. Include the AboutUs component in the src/pages/index.page.tsx page. The AboutPage will be deleted in a future PR.

  • 2. Run npm run prettier:format to format the files.

Copy link
Copy Markdown
Member

@antosan antosan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@antosan antosan added the hacktoberfest-accepted Hacktoberfest acceptance tag label Oct 22, 2022
@antosan antosan merged commit 16107fb into reactdeveloperske:develop Oct 22, 2022
@AJ-Kulundu AJ-Kulundu changed the title Implementaion of About section [Fixes #78] Implementation of About section [Fixes #78] Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Hacktoberfest acceptance tag

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement the About section

2 participants