feat: Add contact form backend functionality#106
feat: Add contact form backend functionality#106orama254 merged 7 commits intoreactdeveloperske:developfrom orama254:contact-form-backend
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
added the contact form functionality to the mobile view of the project. also added an es-lint ignore rule for no-non-null assertions
Initiated a lint and prettier step to enforce uniformity with the rest of the code
There was a problem hiding this comment.
Some general suggestions:
-
1. Can you add
.envto the.gitignorefile? I know we have.env*.localin there but I rarely append.localto my env file and would be nice if the.envis also ignored. -
2. I see this error on the deployment. Did you set all the env variables on Vercel? Is it possible to add the deployment domain to ReCaptcha? How do we verify that it will work once deployed to prod? It would be nice to test the form submission.
- 3. After form submission, the success screen has a lot of white space. Maybe we need to remove the
min-h-screenclass from the contact us section insrc/components/ContactUs/ContactUs.tsx
Remove the min height which created a lot of white space after successfull form submision
|
@orama254 is attempting to deploy a commit to the React Developers Kenya Team on Vercel. A member of the Team first needs to authorize it. |
Initiated a lint and prettier step to enforce uniformity with the rest of the code and calm gh-actions down
@antosan For the second check item, I've added the final production URL and localhost for dev related previews (will be removed once deployed). On localhost it's working fine. For the preview deploys its a bit tricky because the urls keep changing, but I'll try add the url for the preview deploy once the preview build is done to see if it works. |
Okay, let us deploy and check if it works on the production URL. |

Fixes Issue
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers
I've seen some TODO items on the codebase. Should this be a separate issue since we now have the button component?