Skip to content

feat: Add contact form backend functionality#106

Merged
orama254 merged 7 commits intoreactdeveloperske:developfrom
orama254:contact-form-backend
Nov 15, 2022
Merged

feat: Add contact form backend functionality#106
orama254 merged 7 commits intoreactdeveloperske:developfrom
orama254:contact-form-backend

Conversation

@orama254
Copy link
Copy Markdown
Member

@orama254 orama254 commented Nov 7, 2022

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

I've seen some TODO items on the codebase. Should this be a separate issue since we now have the button component?

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
reactdevske-website ✅ Ready (Inspect) Visit Preview Nov 10, 2022 at 3:11PM (UTC)

added the contact form functionality to the mobile view of the project.
also added an es-lint ignore rule for no-non-null assertions
Initiated a lint and prettier step to enforce uniformity with the rest of the code
Copy link
Copy Markdown
Member

@antosan antosan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some general suggestions:

  • 1. Can you add .env to the .gitignore file? I know we have .env*.local in there but I rarely append .local to my env file and would be nice if the .env is also ignored.

  • 2. I see this error on the deployment. Did you set all the env variables on Vercel? Is it possible to add the deployment domain to ReCaptcha? How do we verify that it will work once deployed to prod? It would be nice to test the form submission.

image

  • 3. After form submission, the success screen has a lot of white space. Maybe we need to remove the min-h-screen class from the contact us section in src/components/ContactUs/ContactUs.tsx

Comment thread src/components/ContactUs/DesktopVersion.tsx Outdated
Comment thread src/components/ContactUs/DesktopVersion.tsx Outdated
Comment thread src/components/ContactUs/MobileVersion.tsx Outdated
Comment thread src/components/ContactUs/MobileVersion.tsx Outdated
Remove the min height which created a lot of white space after successfull form submision
@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 10, 2022

@orama254 is attempting to deploy a commit to the React Developers Kenya Team on Vercel.

A member of the Team first needs to authorize it.

Initiated a lint and prettier step to enforce uniformity with the rest of the code and calm gh-actions down
@orama254
Copy link
Copy Markdown
Member Author

Initiated a lint and prettier step to enforce uniformity with the rest of the code

@antosan For the second check item, I've added the final production URL and localhost for dev related previews (will be removed once deployed). On localhost it's working fine. For the preview deploys its a bit tricky because the urls keep changing, but I'll try add the url for the preview deploy once the preview build is done to see if it works.

@antosan
Copy link
Copy Markdown
Member

antosan commented Nov 15, 2022

@antosan For the second check item, I've added the final production URL and localhost for dev related previews (will be removed once deployed). On localhost it's working fine. For the preview deploys its a bit tricky because the urls keep changing, but I'll try add the url for the preview deploy once the preview build is done to see if it works.

Okay, let us deploy and check if it works on the production URL.

Copy link
Copy Markdown
Member

@antosan antosan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

The tests are failing because the images take too long to load and block the site. I have a PR for that here #110

@orama254 orama254 merged commit 807532a into reactdeveloperske:develop Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants