[feature] create footer section#107
Merged
orama254 merged 5 commits intoreactdeveloperske:developfrom Nov 15, 2022
Merged
Conversation
|
@devKiratu is attempting to deploy a commit to a Personal Account owned by @reactdeveloperske on Vercel. @reactdeveloperske first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
antosan
requested changes
Nov 15, 2022
antosan
requested changes
Nov 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Closes #83
Changes proposed
This PR fulfill the following requirements and acceptance criteria
Footerin thecomponentsfolder that implements the screenshots providedLogocomponent.index.page.tsx.e2efolder namedfooter.spec.tsand add a test that verifies that clicking each of the 3 links in the component navigates to the correct URLs./#about-us./#events./#contact-us.footer.spec.tstest should pass on both Chrome, Firefox and Safari.Check List (Check all the applicable boxes)
Screenshots
Desktop footer
Mobile Footer
Passing Footer Component Tests
Note to reviewers
N/A