Skip to content

[feature] create footer section#107

Merged
orama254 merged 5 commits intoreactdeveloperske:developfrom
devKiratu:feature/footer-section
Nov 15, 2022
Merged

[feature] create footer section#107
orama254 merged 5 commits intoreactdeveloperske:developfrom
devKiratu:feature/footer-section

Conversation

@devKiratu
Copy link
Copy Markdown
Contributor

Fixes Issue

Closes #83

Changes proposed

This PR fulfill the following requirements and acceptance criteria

  • Create a component named Footer in the components folder that implements the screenshots provided
  • The menu items are anchor links which should smoothly scroll to the relevant section when clicked.
  • Reuse the Logo component.
  • Include the component in index.page.tsx.
  • Create a new test file in the e2e folder named footer.spec.ts and add a test that verifies that clicking each of the 3 links in the component navigates to the correct URLs.
  • When the "About Us" menu is clicked, the URL changes to /#about-us.
  • When the "Events" menu is clicked, the URL changes to /#events.
  • When the "Contact" menu is clicked, the URL changes to /#contact-us.
  • The implementation should match the design - text content, typography, capitalization and spacing.
  • The UI should be responsive and work well on both desktop and mobile viewports.
  • The footer.spec.ts test should pass on both Chrome, Firefox and Safari.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Desktop footer

reactdevske-footer-large

Mobile Footer

reactdevske-footer-mobile

Passing Footer Component Tests

footer spec ts passing tests

Note to reviewers

N/A

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 11, 2022

@devKiratu is attempting to deploy a commit to a Personal Account owned by @reactdeveloperske on Vercel.

@reactdeveloperske first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
reactdevske-website ✅ Ready (Inspect) Visit Preview Nov 15, 2022 at 10:13AM (UTC)

Comment thread e2e/footer.spec.ts Outdated
@devKiratu devKiratu requested a review from antosan November 15, 2022 08:34
Comment thread src/components/HeroHeader/HeroHeader.tsx
@devKiratu devKiratu requested a review from antosan November 15, 2022 09:49
Copy link
Copy Markdown
Member

@antosan antosan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement the Footer Section

3 participants