Skip to content

Revert "[feature] create footer section" #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmwasonga merged 1 commit into from
Mar 9, 2023
Merged

Revert "[feature] create footer section" #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions e2e/footer.spec.ts
View file
Open in desktop

This file was deleted.

19 changes: 5 additions & 14 deletions e2e/hero-header.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,19 @@ test.describe('Test Hero Header Navigation Links', () => {
test('About us link should navigate to about us section', async ({
page,
}) => {
const headerLocator = page.locator('header');
await headerLocator.getByRole('link', { name: 'About us' }).click();
await page.getByRole('link', { name: 'About us' }).click();
await expect(page).toHaveURL('/#about-us');
});

test('Events link should navigate to Events section', async ({ page }) => {
const headerLocator = page.locator('header');
await headerLocator.getByRole('link', { name: 'Events' }).click();
await page.getByRole('link', { name: 'Events' }).click();
await expect(page).toHaveURL('/#events');
});

test('Contact link should navigate to Contact Us section', async ({
page,
}) => {
const headerLocator = page.locator('header');
await headerLocator.getByRole('link', { name: 'Contact' }).click();
await page.getByRole('link', { name: 'Contact' }).click();
await expect(page).toHaveURL('/#contact-us');
});

Expand All @@ -34,10 +31,7 @@ test.describe('Test Hero Header Navigation Links', () => {
const [newPage] = await Promise.all([
context.waitForEvent('page'),
page.waitForLoadState(),
page
.locator('header')
.getByRole('link', { name: 'Join Community' })
.click(),
page.getByRole('link', { name: 'Join Community' }).click(),
]);
await expect(newPage).toHaveURL(
new RegExp(
Expand All @@ -53,10 +47,7 @@ test.describe('Test Hero Header Navigation Links', () => {
const [newPage] = await Promise.all([
context.waitForEvent('page'),
page.waitForLoadState(),
page
.locator('header')
.getByRole('link', { name: 'Join ReactDevsKe' })
.click(),
page.getByRole('link', { name: 'Join ReactDevsKe' }).click(),
]);
await expect(newPage).toHaveURL(
new RegExp(
Expand Down
10 changes: 0 additions & 10 deletions public/img/love-icon.svg
View file
Open in desktop

This file was deleted.

56 changes: 0 additions & 56 deletions src/components/Footer/Footer.tsx
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/components/Footer/index.ts
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions src/components/HeroHeader/HeroHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ export default function HeroHeader() {
if (!screenWidth) return null;

return (
<header id="hero" className="pt-2">
<div id="hero" className="pt-2">
{screenWidth < breakpoint ? <MobileHero /> : <DesktopHero />}
</header>
</div>
);
}
4 changes: 2 additions & 2 deletions src/components/Navbar/Navbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import LinkButton from '../LinkButton/LinkButton';
export default function Navbar() {
return (
<>
<div className="lg:pl-[49px] w-full bg-transparent">
<header className="lg:pl-[49px] w-full bg-transparent">
<nav className="nav py-4 pl-5 flex flex-col md:flex-row justify-around items-center">
<div>
<Link href={HOME}>
Expand Down Expand Up @@ -41,7 +41,7 @@ export default function Navbar() {
</LinkButton>
</div>
</nav>
</div>
</header>
</>
);
}
2 changes: 0 additions & 2 deletions src/pages/index.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import ContactUs from '../components/ContactUs';
import Events from '../components/Events/Events';
import MissionPillars from '../components/MissionPillars/MissionPillars';
import HeroHeader from '../components/HeroHeader';
import Footer from '../components/Footer';

export default function Home() {
return (
Expand All @@ -30,7 +29,6 @@ export default function Home() {
<MissionPillars />
<Events />
<ContactUs />
<Footer />
</main>
</div>
);
Expand Down