Skip to content

Added fade animation feature on MissionPillar, About, and Event. Text…#129

Merged
orama254 merged 5 commits intoreactdeveloperske:developfrom
Zackius:animation-zack
May 18, 2023
Merged

Added fade animation feature on MissionPillar, About, and Event. Text…#129
orama254 merged 5 commits intoreactdeveloperske:developfrom
Zackius:animation-zack

Conversation

@Zackius
Copy link
Copy Markdown

@Zackius Zackius commented Mar 28, 2023

… border bottom in componenets headers

Added Animation to MissionPillar, About, and Event Files

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 28, 2023

@Zackius is attempting to deploy a commit to a Personal Account owned by @reactdeveloperske on Vercel.

@reactdeveloperske first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reactdevske-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2023 3:22pm

@orama254
Copy link
Copy Markdown
Member

Hello @Zackius

Your preview build seems to be failing on our end. Are the packages resolved correctly on your end?

@Zackius
Copy link
Copy Markdown
Author

Zackius commented Apr 11, 2023

I looked at the issue, packages are resolved.

Copy link
Copy Markdown
Member

@orama254 orama254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zackius
The error happens on the event component as well. Check it out

PATH: /src/components/Events/Events.tsx

@Zackius
Copy link
Copy Markdown
Author

Zackius commented Apr 13, 2023 via email

Copy link
Copy Markdown
Member

@orama254 orama254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out the additional comments for your review.

Comment thread src/components/AboutUs/AboutUs.tsx
Comment thread src/components/ContactUs/DesktopVersion.tsx Outdated
Comment thread src/components/ContactUs/DesktopVersion.tsx Outdated
Comment thread src/components/Events/Events.tsx Outdated
Comment thread src/components/HeroHeader/DesktopHero.tsx
Comment thread src/components/MissionPillars/MissionPillars.tsx Outdated
…d fade direction in events, and desktophero. Removed underline feature on Mission component
Copy link
Copy Markdown
Member

@orama254 orama254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice progress @Zackius ,

also remove the underlines from the about us section heading and the events section heading.

See deployed preview for perspective HERE

Copy link
Copy Markdown
Member

@orama254 orama254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good ✅

@orama254 orama254 merged commit b691a83 into reactdeveloperske:develop May 18, 2023
@orama254 orama254 mentioned this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants