Skip to content

Makes navbar sticky#138

Merged
orama254 merged 5 commits intoreactdeveloperske:developfrom
octaviookumu:make-navbar-sticky
Oct 18, 2023
Merged

Makes navbar sticky#138
orama254 merged 5 commits intoreactdeveloperske:developfrom
octaviookumu:make-navbar-sticky

Conversation

@octaviookumu
Copy link
Copy Markdown

Fixes Issue

Closes #137

Changes proposed

  • Make Navbar accessible when scrolling (Desktop and Mobile)
  • When scrolling, background colour is set to white
  • When having scrolled to top, background colour is reset to transparent
  • Navbar component now contains code for both desktop and mobile navbars

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

  • Scrolling (Desktop)
Screenshot 2023-08-22 at 22 03 35
  • Scrolled to top (Desktop)
Screenshot 2023-08-22 at 22 03 27
  • Scrolling (Mobile)
Screenshot 2023-08-22 at 22 03 15
  • Scrolled to top (Mobile)
Screenshot 2023-08-22 at 22 02 09

Note to reviewers

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 22, 2023

@octaviookumu is attempting to deploy a commit to a Personal Account owned by @reactdeveloperske on Vercel.

@reactdeveloperske first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reactdevske-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 10:35am

@octaviookumu
Copy link
Copy Markdown
Author

Hi @reactdeveloperske. Is there any further action needed on this?

@orama254
Copy link
Copy Markdown
Member

hey @octaviookumu could you run the following commands locally, related to the failing action, on your environment then push it in a new commit?
run-commands-locally

@octaviookumu
Copy link
Copy Markdown
Author

hey @octaviookumu could you run the following commands locally, related to the failing action, on your environment then push it in a new commit? run-commands-locally

Okay. Let me do that. Thanks.

@octaviookumu
Copy link
Copy Markdown
Author

Btw I noticed some existing tests are failing. Also happening on develop branch.

Screenshot 2023-10-17 at 12 12 01

@orama254
Copy link
Copy Markdown
Member

Btw I noticed some existing tests are failing. Also happening on develop branch.

Screenshot 2023-10-17 at 12 12 01

There seems to be an issue with webkit, thats why it's failing. Actively looking into it.

@orama254 orama254 self-requested a review October 18, 2023 10:41
@orama254
Copy link
Copy Markdown
Member

LGTM ✅

@orama254 orama254 merged commit 988ef41 into reactdeveloperske:develop Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants