Skip to content

Add pages, convert files to jsx and create global routes file [Fixes #52] #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
orama254 merged 6 commits into from
Jun 16, 2022
Merged

Add pages, convert files to jsx and create global routes file [Fixes #52] #53

orama254 merged 6 commits into from
Jun 16, 2022

Conversation

@lekipising
Copy link
Contributor

@lekipising lekipising commented Jun 16, 2022

Fixes Issue

Closes #52

Changes proposed

  1. Add the following routes: Members, Events, News, Forum, Contact and About
  2. Convert files to use jsx instead of js
  3. Create global routes file to hold route paths for consistency.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screenshot from 2022-06-16 10-13-32
Screenshot from 2022-06-16 10-13-28
Screenshot from 2022-06-16 10-13-23
Screenshot from 2022-06-16 10-13-17
Screenshot from 2022-06-16 10-13-11
Screenshot from 2022-06-16 10-13-03

Note to reviewers

@vercel
Copy link

vercel bot commented Jun 16, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
reactdevske-website ✅ Ready (Inspect) Visit Preview Jun 16, 2022 at 7:26AM (UTC)

@orama254 orama254 self-requested a review June 16, 2022 12:59
orama254
orama254 approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@orama254 orama254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@orama254
Copy link
Member

orama254 commented Jun 16, 2022

hi @lekipising

This looks good ✅

Thanks 💯

@orama254 orama254 merged commit 28b2d54 into reactdeveloperske:develop Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orama254 orama254 orama254 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lekipising @orama254