Migrate to TypeScript#74
Merged
orama254 merged 3 commits intoreactdeveloperske:developfrom Sep 30, 2022
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for reactdevske ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
orama254
reviewed
Sep 29, 2022
lekipising
reviewed
Sep 29, 2022
| import type { GetStaticProps } from 'next'; | ||
|
|
||
| export const getStaticProps = async () => { | ||
| type EventData = { |
Contributor
There was a problem hiding this comment.
This interface has been defined in src/components/EventsDisplay/DisplayRC.tsx. Perhaps we can create a shared interface and import to all the files using it
Member
Author
There was a problem hiding this comment.
@lekipising Nice observation. Fixed in 760edb9
lekipising
approved these changes
Sep 30, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Changes proposed
As was the plan during the open source challenge, we intended to migrate the codebase to TypeScript after the challenge. This PR implements this migration.
Check List (Check all the applicable boxes)
Note to reviewers
npm run lint- there should be no linter warnings or errorsnpm run test- the available basic test should passnpm run prettier- all files should already be formatted according to the rulesnpm run typecheck- there should be no TypeScript errorsnpm run build- the build should be successfulnpm run dev- the project should run without any errorsI deleted the empty
*.spec.jsxand*.stories.jsxfiles. The setup for these is still in the project and we should add them back as we write the tests and stories.