Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nyandika
reviewed
Oct 21, 2022
| node-version: '14.x' | ||
| - name: Install dependencies | ||
| run: npm ci | ||
| run: npm install |
Contributor
There was a problem hiding this comment.
Any particular reason for this change?
npm ci will run a clean install and it's meant for CI/CD pipelines : reference npm ci docs
Member
Author
There was a problem hiding this comment.
Nice catch, forgot that there while debugging. I have removed it.
nyandika
approved these changes
Oct 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Changes proposed
Fixes failing test in webkit browser
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers