Config feature #28 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

reactive-firewall merged 16 commits into master from config-feature-#28

Jul 24, 2017

Owner

reactive-firewall commented Jul 24, 2017

Added Configuration features #28

reactive-firewall added 10 commits

July 23, 2017 03:21


          - added stickler CI configuration file as part of #32

7c71390

- added some function for config files as part of #28


          - adjusted the coverage exceptions to skip a few more defensive asser…

114156d

…tions that are not triggered

- added new functions for file encryption tasks as part of #20
- added relevent tests for new file encryption functions
- refactored extension utilities
- refactored some tests that caused regression bugs in local testing


          - added fix for file io cross-python regression bug

68ecb3e

- refactored error breakpoints for use while debugging
- fixed failing tests for #20


          added config fopr yaml lint

a5ce3f5


          debugging yamllint more for pr #36

0fa491a


          debugging yamllint more for pr #36

6489f1b


          debugging stickler CI config for pr #36

58ef2a6


          debugging stickler CI config for pr #36

c41f660


          more style debugging stickler CI config for pr #36

f8829cb


          more style debugging stickler CI config for pr #36

a61eb1f

reactive-firewall added PLACEHOLDER Testing Wanted labels

reactive-firewall added this to the Configuration Tooling milestone

reactive-firewall self-assigned this

codecov-io commented Jul 24, 2017 •

edited

Loading

Codecov Report

Merging #37 into master will decrease coverage by 1.2%.
The diff coverage is 16.98%.

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage   83.92%   82.71%   -1.21%     
==========================================
  Files          26       26              
  Lines        2146     2199      +53     
==========================================
+ Hits         1801     1819      +18     
- Misses        345      380      +35

Impacted Files	Coverage Δ
piaplib/pku/config.py	`56.36% <16.98%> (-36.62%)`	⬇️
piaplib/lint/iface_check_status.py	`76.07% <0%> (+1.22%)`	⬆️
piaplib/lint/users_check_status.py	`86.31% <0%> (+2.66%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b4d042...87af121. Read the comment docs.

houndci-bot reviewed

View reviewed changes

tests/test_enc.py

    
              				raise unittest.SkipTest("BETA. Experemental feature not ready yet.")

              		assert theResult

              	def test_case_clearify_read_write(self):

houndci-bot Jul 24, 2017

'CryptoTestSuite.test_case_clearify_read_write' is too complex (14)

reactive-firewall added 2 commits

July 23, 2017 20:07


          revert .stickler.yml

bcb25f1


          added test circleci

a164d0d

Owner Author

reactive-firewall commented Jul 24, 2017

❌ not sure why stickler Ci tests still failing ... might not want this CI test

stickler-ci reviewed

View reviewed changes

.circleci/config.yml

    
            @@ -0,0 +1,21 @@
          
              version: 2

stickler-ci Jul 24, 2017

[warning] missing document start "---" (document-start)

stickler-ci reviewed

View reviewed changes

.stickler.yml

    
            @@ -0,0 +1,11 @@
          
              linters:

stickler-ci Jul 24, 2017

[warning] missing document start "---" (document-start)

stickler-ci reviewed

View reviewed changes

tests/test_enc.py

    
              				raise unittest.SkipTest("BETA. Experemental feature not ready yet.")

              		assert theResult

              	def test_case_clearify_read_write(self):

stickler-ci Jul 24, 2017

C901 'CryptoTestSuite.test_case_clearify_read_write' is too complex (14)


          fix for style pep8

0272d83

houndci-bot reviewed

View reviewed changes

tests/test_enc.py

    
              				raise unittest.SkipTest("BETA. Experemental feature not ready yet.")

              		assert theResult

              	def test_case_clearify_read_write(self):

houndci-bot Jul 24, 2017

'CryptoTestSuite.test_case_clearify_read_write' is too complex (12)

stickler-ci reviewed

View reviewed changes

tests/test_enc.py

    
              				raise unittest.SkipTest("BETA. Experemental feature not ready yet.")

              		assert theResult

              	def test_case_clearify_read_write(self):

stickler-ci Jul 24, 2017

C901 'CryptoTestSuite.test_case_clearify_read_write' is too complex (12)

reactive-firewall added 3 commits

July 23, 2017 20:22


          Merge branch 'master' into config-feature-#28

8e3e0af


          fix for style lint to ignore otherwise working yaml

e595e14


          Merge branch 'config-feature-#28' of https://github.com/reactive-fire…

87af121

…wall/PiAP-python-tools into config-feature-#28

Owner Author

reactive-firewall commented Jul 24, 2017

💯 linters passed 🎆

coveralls commented Jul 24, 2017 •

edited

Loading

Coverage decreased (-1.6%) to 82.765% when pulling 87af121 on config-feature-#28 into 4b4d042 on master.

coveralls commented Jul 24, 2017 •

edited

Loading

Coverage decreased (-1.6%) to 82.765% when pulling 87af121 on config-feature-#28 into 4b4d042 on master.

2 similar comments

coveralls commented Jul 24, 2017

Coverage decreased (-1.6%) to 82.765% when pulling 87af121 on config-feature-#28 into 4b4d042 on master.

coveralls commented Jul 24, 2017

Coverage decreased (-1.6%) to 82.765% when pulling 87af121 on config-feature-#28 into 4b4d042 on master.

coveralls commented Jul 24, 2017 •

edited

Loading

Coverage decreased (-1.6%) to 82.765% when pulling 87af121 on config-feature-#28 into 4b4d042 on master.

coveralls commented Jul 24, 2017 •

edited

Loading

Coverage decreased (-1.6%) to 82.765% when pulling 87af121 on config-feature-#28 into 4b4d042 on master.

2 similar comments

coveralls commented Jul 24, 2017 •

edited

Loading

Coverage decreased (-1.6%) to 82.765% when pulling 87af121 on config-feature-#28 into 4b4d042 on master.

coveralls commented Jul 24, 2017 •

edited

Loading

Coverage decreased (-1.6%) to 82.765% when pulling 87af121 on config-feature-#28 into 4b4d042 on master.

reactive-firewall merged commit 87af121 into master

reactive-firewall added a commit that referenced this pull request


          Merge branch 'config-feature-#28' for PR #37

5f5320f

reactive-firewall deleted the config-feature-#28 branch

July 24, 2017 07:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PLACEHOLDER Testing Wanted