pre-Version 0.4.0 #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## stable #75 +/- ##
==========================================
- Coverage 87.58% 87.42% -0.16%
==========================================
Files 29 30 +1
Lines 3133 3372 +239
==========================================
+ Hits 2744 2948 +204
- Misses 389 424 +35
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## stable #75 +/- ##
==========================================
- Coverage 87.58% 87.51% -0.07%
==========================================
Files 29 29
Lines 3133 3149 +16
==========================================
+ Hits 2744 2756 +12
- Misses 389 393 +4
Continue to review full report at Codecov.
|
9 similar comments
stickler-ci
reviewed
Dec 22, 2018
piaplib/book/__main__.py
Outdated
| except Exception: | ||
| import book.version as version | ||
| for dep in [baseconfig, remediation, logs, version]: | ||
| for dep in [piaplib, baseconfig, remediation, logs, version]: |
houndci-bot
reviewed
Dec 22, 2018
piaplib/book/__main__.py
Outdated
| except Exception: | ||
| import book.version as version | ||
| for dep in [baseconfig, remediation, logs, version]: | ||
| for dep in [piaplib, baseconfig, remediation, logs, version]: |
stickler-ci
reviewed
Dec 22, 2018
| exit(3) | ||
|
|
||
|
|
||
| try: |
There was a problem hiding this comment.
C901 'TryExcept 59' is too complex (17)
houndci-bot
reviewed
Dec 22, 2018
| exit(3) | ||
|
|
||
|
|
||
| try: |
There was a problem hiding this comment.
'TryExcept 59' is too complex (17)
stickler-ci
reviewed
Dec 23, 2018
tests/test_usage.py
Outdated
| theOutputtext = None | ||
| rebootIface = None | ||
| try: | ||
| for someTest in [str("eth0"), str("enp0s")] |
| rebootIface = None | ||
| try: | ||
| for someTest in [str("eth0"), str("enp0s")] | ||
| if theOutputtext is None: |
houndci-bot
reviewed
Dec 23, 2018
| rebootIface = None | ||
| try: | ||
| for someTest in [str("eth0"), str("enp0s")] | ||
| if theOutputtext is None: |
tests/test_usage.py
Outdated
| theOutputtext = None | ||
| rebootIface = None | ||
| try: | ||
| for someTest in [str("eth0"), str("enp0s")] |
* master: PR #33 bug fix for iface typo PR #75 fix for code style regression regression fix for pocket help order attempt to reduce cyclic imports attempt to reduce some test complexity partial fix for cyclic import in piaplib.book partial fix for xeneal test case FIXED test to understand '' =~ None FIXED CLI --help logic and #32 major fixes for code style fix for code-style regression #32 cleaned up some code and started refactor to de-coupled logs from configuration Corner-case of hard to test boiler-plate code exception fix for version function and cleaned up imports a little Version Bump part 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 0.4.0 beta
fix for version syntax bug