Skip to content

Fix: tests fail when 'playwright install-deps' has already run #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Archmonger merged 2 commits into from
Dec 10, 2025
Merged

Fix: tests fail when 'playwright install-deps' has already run #1313

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d84f605
Fix: tests failing when 'playwright install-deps' has already been do…
stevej2608 Dec 10, 2025
016d073
Use contextlib.supress instead of try/except
Archmonger Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from __future__ import annotations

import asyncio
import contextlib
import os
import subprocess

Expand Down Expand Up @@ -36,8 +36,10 @@ def pytest_addoption(parser: Parser) -> None:

@pytest.fixture(autouse=True, scope="session")
def install_playwright():
subprocess.run(["playwright", "install", "chromium"], check=True) # noqa: S607, S603
subprocess.run(["playwright", "install-deps"], check=True) # noqa: S607, S603
subprocess.run(["playwright", "install", "chromium"], check=True) # noqa: S607
# Try to install system deps, but don't fail if already installed or no root access
with contextlib.suppress(subprocess.CalledProcessError):
subprocess.run(["playwright", "install-deps"], check=True) # noqa: S607


@pytest.fixture(autouse=True, scope="session")
Expand All @@ -49,7 +51,7 @@ def rebuild():
# passed to the subprocess.
env = os.environ.copy()
env.pop("HATCH_ENV_ACTIVE", None)
subprocess.run(["hatch", "build", "-t", "wheel"], check=True, env=env) # noqa: S607, S603
subprocess.run(["hatch", "build", "-t", "wheel"], check=True, env=env) # noqa: S607


@pytest.fixture(autouse=True, scope="function")
Expand Down
Loading