Extend descriptions of ObservableChangeSet methods#292
Merged
RolandPheasant merged 2 commits intoreactivemarbles:masterfrom Oct 21, 2019
Merged
Extend descriptions of ObservableChangeSet methods#292RolandPheasant merged 2 commits intoreactivemarbles:masterfrom
RolandPheasant merged 2 commits intoreactivemarbles:masterfrom
Conversation
Added description of the special difference between the ToObservableChangeSet and AsObservableChangeSet methods
|
|
Member
|
You may want to add fullstop characters after each sentence. "." -- reason is when they are read by visual studio they are just made into one line anyway. |
Collaborator
|
@glennawatson I agree with the full stops. @lexisstv would you mind adding them and do a further commit? |
Contributor
Author
|
@RolandPheasant Ok, I do it. |
RolandPheasant
approved these changes
Oct 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added description of the special difference between the ToObservableChangeSet and AsObservableChangeSet methods
What kind of change does this PR introduce?
comments update
What is the current behavior?
Two closed in name methods works different. One track item changes and another not.
What is the new behavior?
The method description now shows changetracking behavior
What might this PR break?
nothing
Please check if the PR fulfills these requirements
Other information: