Improve sequencers, scheduling, and signal APIs#1
Merged
Conversation
Fix generator bridge emission and refactor primitives across concurrency and signal code. Key changes: - Generators: add marker sources and only emit bridge source when corresponding R3/System.Reactive types are referenced. - Sequencers: introduce shared Now via TimeProvider (when available), add thread-static state and helpers to CurrentThreadSequencer, unify Now usage in ImmediateSequencer, add default capacity for SequencerQueue. - Scheduling/runtime: overhaul ScheduledItem (IComparable impl, safer disposal, use RuntimeHelpers.GetHashCode), add ScheduledItem<TAbsolute,TValue> fields, and refactor recursive scheduling in Sequencer.Simple into a RecursiveScheduleState helper with proper null checks. - Threading: add guards and comments to ThreadPoolSequencer, adjust TaskPoolSequencer MultipleDisposable usage. - Virtual time: improve VirtualTimeSequencerBase/VirtualTimeSequencer with clearer control flow, stopwatch backed by virtual clock, and small API fixes. - Connectable signals: add XML-docs, parameter/argument checks, AutoConnect convenience overload, and internal gate types (RefCountGate/AutoConnectGate) to manage connection lifetimes safely. - Broadcaster: make struct equatable and add clearer observer management helpers. - Misc: numerous documentation comments, small API surface improvements, and defensive null/argument checks across tests and primitives. These changes improve correctness, safety, and readability of scheduling and signal primitives while ensuring generators only emit bridge code when appropriate.
|
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix generator bridge emission and refactor primitives across concurrency and signal code.
Key changes:
These changes improve correctness, safety, and readability of scheduling and signal primitives while ensuring generators only emit bridge code when appropriate.