Remove ExcludeFromCodeCoverage & add tests#3
Merged
Merged
Conversation
Remove System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage attributes across many primitives and signals so production code is included in coverage. Update .editorconfig and .gitattributes to normalize repository line endings to CRLF (including shell scripts). Add AssemblyInfo with InternalsVisibleTo to allow tests access to internals. Adjust testconfig.json coverage settings to include ReactiveUI.Primitives assemblies and exclude tests/benchmarks, and fix a null-dispose in CatchSignal. Add new test files to expand coverage (CoverageExpansionTests, CoverageRuntimeTests, OperatorCoverageExpansionTests).
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3 +/- ##
==========================================
- Coverage 81.58% 77.11% -4.48%
==========================================
Files 21 99 +78
Lines 239 4951 +4712
Branches 47 865 +818
==========================================
+ Hits 195 3818 +3623
- Misses 34 857 +823
- Partials 10 276 +266 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Refactor Signal<T> internals to consolidate subscription targets into a SignalSubscription _target (observer or Action) and remove the previous _onNext delegate. Streamline OnNext/OnError/OnCompleted dispatching, improve array subscription removal logic, and simplify action/observer fast-path checks. Expose Start and Count on RangeSignal and add a specialized RangeZipSignal<TResult> plus a zip fast-path in SignalOperatorMixins to zip two integer ranges without coordinator queues. Add a suite of benchmark files (factory/adapter, higher-order, time/scheduler, connectable/share, terminal collections, state/task/command) and extend Program to run expansion smoke tests. Update tests to cover disposal paths, single-observer lifecycle, and RangeZip semantics.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage attributes across many primitives and signals so production code is included in coverage.
Update .editorconfig and .gitattributes to normalize repository line endings to CRLF (including shell scripts).
Add AssemblyInfo with InternalsVisibleTo to allow tests access to internals.
Adjust testconfig.json coverage settings to include ReactiveUI.Primitives assemblies and exclude tests/benchmarks, and fix a null-dispose in CatchSignal.
Add new test files to expand coverage (CoverageExpansionTests, CoverageRuntimeTests, OperatorCoverageExpansionTests).