housekeeping: Make debug type use portable format and embedded. #1742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required for sourcelink to function on non-netstandard platforms. This will embed the PDB inside the file.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for sourcelink to function on non-netstandard platforms.
This will embed the PDB inside the file.
See https://github.com/dotnet/core/blob/master/Documentation/diagnostics/portable_pdb.md
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fixes sourcelink functionality. It isn't compatible with the old non-documented "full" debug method. .NET Standard by default uses the new portable, and this will make the .net framework use it as well.
What is the current behavior? (You can also link to an open issue here)
Use full where it can which is the older legacy PDB version.
What is the new behavior (if this is a feature change)?
Use embedded which will simplify debugging on RxUI. This matches Rx.NET which also embeds.
What might this PR break?
This will increase our executable size by about 20% but will make it easier for consumers to use our code base. This matches a lot of Microsoft and Rx.NET frameworks.