Skip to content

Conversation

@kdubau
Copy link
Contributor

@kdubau kdubau commented Oct 17, 2018

Some test scenarios cannot depend on cake locating VS/MSBuild correctly.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Allows explicitly specifying VS and MSBuild to your cake script.

What is the current behavior? (You can also link to an open issue here)

Relies on cake to locate VS.

What is the new behavior (if this is a feature change)?

VS/MSbuild can be specified to cake, if not falls back to cake locator.

What might this PR break?

I suppose it could break the cake script..

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

Required for #1615

Some test scenarios cannot depend on cake locating VS/MSBuild correctly.
@glennawatson glennawatson merged commit 8a777eb into reactiveui:master Oct 17, 2018
@kdubau kdubau deleted the explicit-vslocation branch October 18, 2018 15:12
glennawatson pushed a commit that referenced this pull request Mar 23, 2019
)

Some test scenarios cannot depend on cake locating VS/MSBuild correctly.
@lock lock bot locked and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants