refactor: Remove ReactiveCommand abstract class. #1836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ff ICommand it can be an issue for binding etc
RLittlesII
previously approved these changes
Nov 7, 2018
Member
RLittlesII
left a comment
RLittlesII
left a comment
There was a problem hiding this comment.
Glenn. This LGTM. I would say we need another member of the @reactiveui/core-team to make sure there are no major concerns.
olevett
previously approved these changes
Nov 7, 2018
Member
olevett
left a comment
olevett
left a comment
There was a problem hiding this comment.
Looks good, assume this is a reasonably major version change?
Contributor
Author
|
Will take us to 9.1 or 10. If we follow semantic versioning I guess 10 |
glennawatson
dismissed stale reviews from worldbeater, olevett, and RLittlesII
via
d691915
delete-merged-branch
bot
deleted the
glennawatson-remove-reactivecommand-abstract
branch
glennawatson
added a commit
that referenced
this pull request
Mar 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This removes the abstract base class we use in ReactiveCommand.
What is the current behavior? (You can also link to an open issue here)
There is a abstract base class. Users can introduce subtle bugs by using it directly in their code. It was meant for interop with the ICommand but now ReactiveCommandBase<TParam, TResult> now implements that logic. There is also a interface allow some of the Command Binding code to keep functioning and exposes the observables for the user. It's deliberately not derived from ICommand due to us wanting the separation.
What is the new behavior (if this is a feature change)?
refactor.
What might this PR break?
Users who have a derived off the abstract base class. They will have to change their classes to derive from ReactiveCommandBase<TParam, TResult> now.
Please check if the PR fulfills these requirements
Other information:
Docs have already been modified to show the non-abstract class use.
This relates to reactiveui/rfcs#19